Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magazine wells for WS CDLC #1539

Merged
merged 16 commits into from
Sep 22, 2023

Conversation

Dahlgren
Copy link
Contributor

@Dahlgren Dahlgren commented Mar 23, 2022

When merged this pull request will:

  • Enable WS weapons to use magazines implementing CBA magazine wells
  • Enable WS magazines to be used in other weapons implementing CBA magazine wells

@jonpas jonpas added this to the 3.16.0 milestone Sep 6, 2023
@Dahlgren Dahlgren marked this pull request as ready for review September 6, 2023 20:17
@Dahlgren
Copy link
Contributor Author

Dahlgren commented Sep 7, 2023

Needs to be tested in game for UBC issues and inconsistencies.

The underbarrel grenade launchers have not been updated with CBA JAM magazine wells.

@Mike-MF
Copy link
Contributor

Mike-MF commented Sep 7, 2023

These are WS Guns using magazines available via magwells from this PR. Pretty much none of them fit (Only affecting the AA40, SLR & Galil) they'd probably benefit from an alternative magwell.

107410_20230907174302_1
107410_20230907174345_1
107410_20230907174519_1

@Drofseh
Copy link
Contributor

Drofseh commented Sep 7, 2023

Having an alternative magwell seems to defeat the point of magwells to me.
I'd rather have magazine compatibility that looks a little ugly than magazines that aren't compatible.

@jonpas
Copy link
Member

jonpas commented Sep 13, 2023

Rifles that don't fit other mags should have magwells removed.

@jonpas jonpas merged commit 712ca61 into CBATeam:master Sep 22, 2023
4 checks passed
@Dahlgren Dahlgren deleted the feature/ws-magazine-wells branch September 22, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants